SearchInput: skip state updates after unmount

2020-10-10 18:05:21 -04:00
parent 571a67d793
commit 1876e38aa9
1 changed files with 3 additions and 1 deletions
--- a/src/components/SearchInput/SearchInput.tsx
+++ b/src/components/SearchInput/SearchInput.tsx
@@ -15,10 +15,12 @@ const SearchInput: React.FC<SearchInputProps> = () => {

  /* eslint-disable react-hooks/exhaustive-deps */
  useEffect(() => {
+    let isMounted = true;
    if (value !== query) {
-      setValue(query);
+      isMounted && setValue(query);
      ReactGA.event({ category: "Search", action: "Tag", label: query });
    }
+    return () => void (isMounted = false);
  }, [query]);
  /* eslint-enable react-hooks/exhaustive-deps */