andrea/phosphor-icons
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SearchInput: skip state updates after unmount

Browse Source
This commit is contained in:
rektdeckard
2020-10-10 18:05:21 -04:00
parent 571a67d793
commit 1876e38aa9
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/SearchInput/SearchInput.tsx
View File

@@ -15,10 +15,12 @@ const SearchInput: React.FC<SearchInputProps> = () => {
/* eslint-disable react-hooks/exhaustive-deps */ /* eslint-disable react-hooks/exhaustive-deps */
useEffect(() => { useEffect(() => {
let isMounted = true;
if (value !== query) { if (value !== query) {
setValue(query); isMounted && setValue(query);
ReactGA.event({ category: "Search", action: "Tag", label: query }); ReactGA.event({ category: "Search", action: "Tag", label: query });
} }
return () => void (isMounted = false);
}, [query]); }, [query]);
/* eslint-enable react-hooks/exhaustive-deps */ /* eslint-enable react-hooks/exhaustive-deps */